Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the event bus optional #547

Merged
merged 1 commit into from
Mar 22, 2024
Merged

make the event bus optional #547

merged 1 commit into from
Mar 22, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Mar 21, 2024 •
edited
Loading

The event bus is no longer required to react to events in the form of a processor or projector. We now have the option to handle everything with the subscription engine. That's why the event bus should no longer be required, but optional.

@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Mar 21, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Mar 21, 2024
@DavidBadura DavidBadura self-assigned this Mar 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------------+------------+
|                           | time (kde mode)                   | memory                       |
+---------------------------+-----------------+-----------------+-----------------+------------+
| subject                   | Tag: <current>  | Tag: base       | Tag: <current>  | Tag: base  |
+---------------------------+-----------------+-----------------+-----------------+------------+
| benchHandle10000Events () | 3.217s (±0.00%) | 3.265s (±0.00%) | 39.094mb        | 39.098mb   |
+---------------------------+-----------------+-----------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 5.402ms (±0.00%)   | 5.440ms (±0.00%)   | 42.563mb        | 42.564mb   |
| benchSave10000Events () | 525.491ms (±0.00%) | 619.436ms (±0.00%) | 42.574mb        | 42.841mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 161.105ms (±0.00%) | 161.830ms (±0.00%) | 38.698mb        | 38.699mb   |
| benchSave1Event ()                     | 929.900μs (±0.00%) | 866.300μs (±0.00%) | 38.698mb        | 38.699mb   |
| benchSave10000Events ()                | 381.391ms (±0.00%) | 455.351ms (±0.00%) | 38.698mb        | 38.965mb   |
| benchSave10000Aggregates ()            | 9.246s (±0.00%)    | 9.177s (±0.00%)    | 38.698mb        | 38.699mb   |
| benchSave10000AggregatesTransaction () | 7.319s (±0.00%)    | 7.334s (±0.00%)    | 38.698mb        | 38.699mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 162.696ms (±0.00%) | 157.509ms (±0.00%) | 38.695mb        | 38.696mb   |
| benchLoad10000Events ()                | 503.900μs (±0.00%) | 505.300μs (±0.00%) | 38.695mb        | 38.696mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit ecf5795 into 3.0.x Mar 22, 2024
33 of 35 checks passed
@DavidBadura DavidBadura deleted the optional-event-bus branch March 22, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees

@DavidBadura DavidBadura

Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura